https://bugzilla.redhat.com/show_bug.cgi?id=2000219 --- Comment #5 from Dan Čermák <dan.cermak@xxxxxxxxxxxxxxxxxxx> --- Thanks for the improvements! A few additional suggestions: - You should own the directory %_libdir/llvm-unwind - The devel package *must* require the main package as follows: Requires: %{name}%{?_isa} = %{version}-%{release} (then you can also drop the %license in the devel package) - the BuildArch: noarch is wrong, you cannot build only the documentation anyway and the rest is arch specific - remove the file html/.buildinfo, it is not required in the rpm - there is no changelog (I would recommend to use rpmautospec) - please link the patch to a upstream pull request or add a note in the spec why it is not upstreamable - you can save yourself the manual copying of the documentation and just put a %doc libunwind/html into the %files doc section -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
