https://bugzilla.redhat.com/show_bug.cgi?id=2000219 --- Comment #3 from Dan Čermák <dan.cermak@xxxxxxxxxxxxxxxxxxx> --- Here's a few notes/suggestions for the current state: - the license is wrong, the project ships the Apache2 License with the LLVM exception, but the spec mentions the MIT or NCSA - the package must own %_libdir/llvm-unwind - the package ships no headers, which is rather odd for a shared library - the shared library should go into a -devel subpackage - no tests are run - why do you install the shared library into a subfolder of %_libdir instead of %_libdir? - upstream has a documentation that is not being build, why is that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure