[Bug 1998894] Review Request: rust-automod - Pull in every source file in a directory as a module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1998894

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
(In reply to Iago Rubio from comment #2)
> Package looks good so far.

Thanks for the quick unofficial review!

> rpmbuild did not rebuilt on my rawhide devel system due to missing macro
> (crate(proc-macro2/default)). Package  rust-proc-macro2-devel did not gets
> pulled by rust-packaging nor cargo was able to resolve this dependency.
> 
> May be due a missconfiguration on this machine.
> 
> Just pointing to it, so you can have this into account.

This is not really a misconfiguration, but plain "rpmbuild -ba / -bb" do not
support all new RPM features out-of-the box, like generated BuildRequires,
which the Rust (and other new packaging stacks, like modern python packaging)
use.

For this reason (and other reasons), I usually recommend new packagers not even
to bother with plain "rpmbuild -ba / -bb" for building binary packages from
source packages, but to start off by using "mock" (a build tool that basically
runs everything in a clean Fedora container) instead. That's what official
builds on Fedora build servers (koji) and unofficial community builds in COPR
use anyway, so you'd need to learn to deal with mock anyway at some point.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux