https://bugzilla.redhat.com/show_bug.cgi?id=1998894 Iago Rubio <iago@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iago@xxxxxxxxxxxxx --- Comment #2 from Iago Rubio <iago@xxxxxxxxxxxxx> --- Hi Fabio, not a packager yet, just doing the review. * rpmlint - no errors, it just issues erroneus warning (about the %autochangelog macro) * rust2rpm package * fedora-review - no warnings. * manual review: - Package license is ok (ASL or MIT) - License files included in package - No bundled libraries - Changelog provided by macro, so good format expected. - Sources are only permisible code & content - No desktop file (crate package) - No hardcoded directories - Name accoroding Package Name Guidelines - It's not a rename. No obsoletes. - No Requires but BuildRequire on rust-packaging - Correct language on spec file - No systemd files needed - No excludearch. noarch package - No large doc, doc package not required (10240 bytes, 1 file) Builds on mock (fedora-rawhide-x86_64). Package looks good so far. rpmbuild did not rebuilt on my rawhide devel system due to missing macro (crate(proc-macro2/default)). Package rust-proc-macro2-devel did not gets pulled by rust-packaging nor cargo was able to resolve this dependency. May be due a missconfiguration on this machine. Just pointing to it, so you can have this into account. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
