https://bugzilla.redhat.com/show_bug.cgi?id=1990149 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ Doc Type|--- |If docs needed, set a value Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - (almost) latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Three minor issues: 1) Version 0.3.2 was released since you filed the review request. Update from 0.3.1 to 0.3.2 before or after importing, if possible. 2) Maybe drop the Markdown markup from Summary (the backticks around `--verbose`), or replace them with normal quotation marks (")? I know of no place in the ecosystem that renders Summary or %description text as markdown, so they are only weird for no benefit. 3) Drop "examples" from "%doc". As mentioned in the other reviews, this is superfluous since the "examples" directory is already included in the -devel package anyway. Please take these into account when importing / building the package. Other than that, Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
