https://bugzilla.redhat.com/show_bug.cgi?id=1990500 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |decathorpe@xxxxxxxxx Flags| |fedora-review+ Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Four minor issues: 1) The value for the Summary tag is too long. E: summary-too-long C Derive macro for implementing the display Trait via a doc comment and string interpolation Please trim this to some sensible shorter version. 2) Also, leave the "# Initial patched metadata" comment intact. It's basically a marker for "this patch was generated automatically by rust2rpm -p, do this again if you're updating this package". 3) Please file a PR with https://github.com/yaahc/displaydoc with the static_assertions bump. 4) Please drop "README.tpl" (a cargo-readme template file?) and "examples" from %doc. They are both useless in Fedora. Other than that, Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
