https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #3 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you for review, I will reply and update the spec in tomorrow (perhaps). Just some notes: * %{nil} convention This is useful when I want to add additional lines after "spec \" line. When not using %{nil}, I have to write "spec" (ends here), and when I want to add additional line, I have to change the line to "spec \", while using %nil as "sentinel", this can make diff a bit smaller. * Doc subpackage could be noarch. Actually I wonder why gem2rpm writes "noarch" to subpackage... When the main package is marked as "BuildArch: noarch", all subpackages becomes noarch automatically. (Conversely: we cannot make subpackage arch-dependent when writing main package as "BuildArch: noarch") * You do not have to move the gemspec file in %prep. This is to clean up build dir after rebuild. When you do "$ rpmbuild --rebuild *.src.rpm" or "$ fedpkg --release f34 local -- --clean", you can see: ------------------------------------------------------- Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/tasaka1/rpmbuild/INSTROOT/rubygem-image_size-2.1.1-1.fc34-foo-tasaka1 Wrote: /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review/rubygem-image_size-2.1.1-1.fc34.src.rpm Wrote: /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review/noarch/rubygem-image_size-2.1.1-1.fc34.noarch.rpm Wrote: /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review/noarch/rubygem-image_size-doc-2.1.1-1.fc34.noarch.rpm Executing(%clean): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.9WXLyW + umask 022 + cd /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review + cd image_size-2.1.1 + /usr/bin/rm -rf /home/tasaka1/rpmbuild/INSTROOT/rubygem-image_size-2.1.1-1.fc34-foo-tasaka1 + RPM_EC=0 ++ jobs -p + exit 0 Executing(--clean): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.ENZqEC + umask 022 + cd /home/tasaka1/rpmbuild/fedora-specific/RUBYGEMS/rubygem-image_size/Review + rm -rf image_size-2.1.1 <======================================== + RPM_EC=0 ++ jobs -p + exit 0 ------------------------------------------------------- Without moving every unpackaged files under the directory specfied by "%setup -n" option, files are not cleaned up after rpmbuild. Actually I oppose to use directories outside the one specified by "%setup -n". * I will ask the upstream to modify FSF address later, however for now I will leave this as it is. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
