https://bugzilla.redhat.com/show_bug.cgi?id=1992931 --- Comment #2 from Jarek Prokop <jprokop@xxxxxxxxxx> --- Rpmlint is complaining about FSF's address in the GPL license file; it seems upstream might have an old license file? ~~~ $ rpmlint ./srpm-unpacked/rubygem-image_size.spec srpm/rubygem-image_size-2.1.1-1.fc34.src.rpm results/rubygem-image_size-2.1.1-1.fc35.noarch.rpm == rpmlint session starts == rpmlint: 2.0.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 rubygem-image_size.noarch: E: incorrect-fsf-address /usr/share/gems/gems/image_size-2.1.1/GPL ~~~ * `export RUBY_LIB=$(pwd)/lib` in %check does not do anything (or shouldn't) - Ruby's manpage specifies that the correct variable name is `RUBYLIB` - it does not seem to be required to run the test suite (I tested it) * `%{nil}` is used. I am not really sure what it does? Why is it being supplied to the rm -rf? Small nits (not blockers): * Doc subpackage could be noarch. * You do not have to move the gemspec file in %prep. The path a level above can be supplied as well; like so: `gem build ../%{gem_name}-%{version}.gemspec`. * Consider using `gem2rpm`, which does most of the work for you in the case of RubyGems in a standardized way. * JFTR, the upstream's gemspec, Gemfile, and `spec/` test suite can be included in the *-doc subpackage as it can be used for a reference. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
