https://bugzilla.redhat.com/show_bug.cgi?id=1992877 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(loganjerry@gmail. | |com) | --- Comment #5 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Ben Beasley from comment #4) > - Since you are invoking the autotools (autoreconf), I think you should > explicitly add > > BuildRequires: autoconf > BuildRequires: automake > > rather than relying on an indirect dependency via > > BuildRequires: libtool Done. > - There are no upstream tests, but it would be nice to do a “smoke test” with > one of the examples from > > https://doc.sagemath.org/html/en/reference/interfaces/sage/interfaces/qsieve. > html, > something like this: > > %check > # Example from > # > https://doc.sagemath.org/html/en/reference/interfaces/sage/interfaces/qsieve. > html > factors="$( > echo '1000000000000000005490000000000000001989' | > %{buildroot}%{_bindir}/QuadraticSieve | > awk 'f; /^FACTORS:$/ {f=1}' | sort -n -u | tr '\n' ' ' > )" > [ "${factors}" = '10000000000000000051 100000000000000000039 ' ] > > What do you think? Good idea, thanks! I've added exactly the one you suggested. > - A man page is always wanted (“SHOULD”) for a command-line tool > (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages). > > Normally I would offer to write one, but it’s hard to clearly document > exactly what outputs to expect, and what inputs will produce useful > results, without extensive study—even > > https://doc.sagemath.org/html/en/reference/interfaces/sage/interfaces/qsieve. > html > doesn’t do a great job—so I don’t really want to do that in this case. Hmmm. Well, on the plus side, the command line tool takes no arguments whatsoever, so documenting that part is easy. :-) On the other hand, like you, I would have to study this tool for awhile to write a reasonable man page. The binary is meant to be invoked from sagemath anyway. I don't really expect anyone to run it directly from the command line. All things considered, I would like to take a pass on providing a man page for this package. New URLs: Spec URL: https://jjames.fedorapeople.org/flintqs/flintqs.spec SRPM URL: https://jjames.fedorapeople.org/flintqs/flintqs-1.0-2.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
