https://bugzilla.redhat.com/show_bug.cgi?id=1980562 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Jerry James <loganjerry@xxxxxxxxx> --- That looks good. This package is APPROVED. One little nitpick: when you import, please put $LDFLAGS *before* -lm. That way -Wl,--as-needed applies to -lm. With the ongoing absorption of libm into libc, this will drop the libm dependency if at some future time all of the needed symbols have been moved to libc. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
