https://bugzilla.redhat.com/show_bug.cgi?id=1983175 --- Comment #2 from Major Hayden 🤠 <mhayden@xxxxxxxxxx> --- (In reply to Lukáš Zaoral from comment #1) > Hi Major, > note, that I'm not a member of the packager group yet and this is one of the > reviews I have to write to become one. Therefore, some of my suggestions or > remarks may not be perfect. Thank you for understanding and patience until > some official member responds to your review request (and reviews my review). Everyone starts somewhere! 🎉 Thanks for having a look. > The spec file looks great! I have only a few remarks: > > * I see that you explicitly disable bundled unit tests. You should try to > enable them or provide a reason for not doing so. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites. The Arch Linux folks disabled them, too, and it's because the repo brings in extra requirements via submodules which end up being installed in the final package. Even if you package 'googletest', the cmake stuff will need to be heavily patched to use it. I'll add some commentary in there about that. > * Could you provide a Koji build to demonstrate that all architectures can > be built successfully? (Your COPR build is x86_64 only.) Here's a new COPR build from this morning with everything included: https://copr.fedorainfracloud.org/coprs/mhayden/python-google-cloud/build/2353456/ I sent a scratch build through Koji, too: https://koji.fedoraproject.org/koji/taskinfo?taskID=72972061 > * rpmlint issues following warning: library-not-linked-against-libc > /usr/lib64/libcrc32c.so.1.1.0 I'm not entirely sure how to correct this or how big of an issue it might be. > * Just a nitpick: It may be useful to replace all occurrences of > google-crc32c by %{name}. Good point. I'll go back through and use that more often. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
