https://bugzilla.redhat.com/show_bug.cgi?id=1983175 Lukáš Zaoral <lzaoral@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lzaoral@xxxxxxxxxx --- Comment #1 from Lukáš Zaoral <lzaoral@xxxxxxxxxx> --- Hi Major, note, that I'm not a member of the packager group yet and this is one of the reviews I have to write to become one. Therefore, some of my suggestions or remarks may not be perfect. Thank you for understanding and patience until some official member responds to your review request (and reviews my review). The spec file looks great! I have only a few remarks: * I see that you explicitly disable bundled unit tests. You should try to enable them or provide a reason for not doing so. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites. * Could you provide a Koji build to demonstrate that all architectures can be built successfully? (Your COPR build is x86_64 only.) * rpmlint issues following warning: library-not-linked-against-libc /usr/lib64/libcrc32c.so.1.1.0 * Just a nitpick: It may be useful to replace all occurrences of google-crc32c by %{name}. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
