https://bugzilla.redhat.com/show_bug.cgi?id=1986844 Gustavo Costa <xfgusta@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |xfgusta@xxxxxxxxx --- Comment #1 from Gustavo Costa <xfgusta@xxxxxxxxx> --- Hi Aníbal. I'm not a packager yet, but I have some things to point out about your spec file: * The %{?dist} tag should be used in the Release field [1] Release: 1%{?dist} * The upstream points to ircii.warped.com to get the source code [2] Source: http://ircii.warped.com/%{name}-%{version}.tar.gz * Group, Vendor, and Packager fields should be not used [3] * Since gcc, make, ncurses, and openssl is used to build ircii, you have to use them BuildRequires: gcc BuildRequires: make BuildRequires: ncurses-devel BuildRequires: openssl-devel * There are macros for configure and make build, you can use them %configure --mandir=%{buildroot}/%{_mandir} %make_build Note that "--mandir=%{buildroot}/%{_mandir}" is used because the upstream expect this [4] * In the build section, you can use the make_install macro %make_install * By using the macros above, the files will be installed in the right place (prefix=/usr) [5]. You should use macros like _bindir and datadir to install the files. You can also use glob %{_bindir}/irc %{_bindir}/irc-%{version} %{_bindir}/ircbug %{_bindir}/ircflush %{_libexecdir}/ircio %{_libexecdir}/wserv %{_datadir}/irc/* %{_mandir}/man1/irc.1* %{_mandir}/man1/ircII.1* %{_mandir}/man1/ircbug.1* * You have to use the changelog field to report your changes in the spec file [6] %changelog * Wed Jul 28 2021 Anibal Monsalve <anibal@xxxxxxx> - 20210314-1 - Initial package References ---------- 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ 2. "You can fetch ircII from the following places: America [main site] (San Jose, CA) http://ircii.warped.com/"; http://www.eterna.com.au/ircii 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections 4. "@mandir@ tends to be $datarootdir which already has $DESTDIR" http://ircii.warped.com/ircii-current/ircii/Makefile.in 5. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_no_files_or_directories_under_srv_usrlocal_or_homeuser 6. https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs The final spec file: https://gist.githubusercontent.com/xfgusta/148cc68fdbcfa70d2bc582d404c7f3fa/raw/9c0361a8f0e862c7fb4255f16a0b381187d2d451/ircii.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
