https://bugzilla.redhat.com/show_bug.cgi?id=1986953 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |michel@xxxxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |michel@xxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- (In reply to Raphael Groner from comment #4) > Raphael Groner 2021-03-04 18:59:12 UTC > Some hints to your spec file: > > … > o may additionally to BR add also Requires: procps-ng - is that a weak > dependency, why Fedora only? That's provided by the BR on %{_bindir}/ps, no? > o please consider to generate documentation and ship in a doc subpackage > … > o use systemd macros in %post and %postun > https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/ > #_systemd This package does not ship unit files, not sure this is relevant -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
