[Bug 1985398] Review Request: pack - Convert code into runnable images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1985398

Lokesh Mandvekar <lsm5@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(lsm5@xxxxxxxxxx)  |



--- Comment #6 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> ---
(In reply to Jindrich Novy from comment #5)

Thanks Jindrich, most issues are fixed, rest justified below. PTAL.

Try: fedora-review --copr-build 2349648 
https://copr.fedorainfracloud.org/coprs/lsm5/pack/builds/


> 
> Rpmlint
> -------
> Checking: pack-0.20.0-1.fc35.x86_64.rpm
>           pack-0.20.0-1.fc35.src.rpm
> pack.x86_64: E: description-line-too-long C pack is a CLI implementation of
> the Platform Interface Specification for Cloud Native Buildpacks.


Fixed

> pack.x86_64: W: incoherent-version-in-changelog 1.21.3-3 ['0.20.0-1.fc35',
> '0.20.0-1']

Fixed

> pack.x86_64: W: invalid-url URL https://https://github.com/buildpacks/pack

Fixed

> pack.x86_64: W: unstripped-binary-or-object /usr/bin/pack


Fixed

> pack.x86_64: W: no-manual-page-for-binary pack

No upstream manpage, I can file a request but shouldn't be a blocker afaict.


> pack.src: E: description-line-too-long C pack is a CLI implementation of the
> Platform Interface Specification for Cloud Native Buildpacks.


Fixed

> pack.src: W: invalid-url URL https://https://github.com/buildpacks/pack


Fixed

> pack.src: W: invalid-url Source0: v0.20.0-vendor.tar.gz


Upstream doesn't vendor deps, so I created a tarball locally with vendored
deps.


> 2 packages and 0 specfiles checked; 2 errors, 8 warnings.
> 
> 
> [!] Can you please fix the above Lokesh?
> 


Let me know ...


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux