https://bugzilla.redhat.com/show_bug.cgi?id=1985398 Jindrich Novy <jnovy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(lsm5@xxxxxxxxxx) --- Comment #5 from Jindrich Novy <jnovy@xxxxxxxxxx> --- Thank Lokesh, copr worked as expected. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. It does build in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pack-0.20.0-1.fc35.x86_64.rpm pack-0.20.0-1.fc35.src.rpm pack.x86_64: E: description-line-too-long C pack is a CLI implementation of the Platform Interface Specification for Cloud Native Buildpacks. pack.x86_64: W: incoherent-version-in-changelog 1.21.3-3 ['0.20.0-1.fc35', '0.20.0-1'] pack.x86_64: W: invalid-url URL https://https://github.com/buildpacks/pack pack.x86_64: W: unstripped-binary-or-object /usr/bin/pack pack.x86_64: W: no-manual-page-for-binary pack pack.src: E: description-line-too-long C pack is a CLI implementation of the Platform Interface Specification for Cloud Native Buildpacks. pack.src: W: invalid-url URL https://https://github.com/buildpacks/pack pack.src: W: invalid-url Source0: v0.20.0-vendor.tar.gz 2 packages and 0 specfiles checked; 2 errors, 8 warnings. [!] Can you please fix the above Lokesh? Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- pack (rpmlib, GLIBC filtered): glibc libc.so.6()(64bit) Provides -------- pack: bundled(golang(github.com/BurntSushi/toml)) bundled(golang(github.com/Masterminds/semver)) bundled(golang(github.com/Microsoft/hcsshim)) bundled(golang(github.com/apex/log)) bundled(golang(github.com/buildpacks/lifecycle)) bundled(golang(github.com/containerd/containerd)) bundled(golang(github.com/docker/docker)) bundled(golang(github.com/docker/go-connections)) bundled(golang(github.com/ghodss/yaml)) bundled(golang(github.com/golang/mock)) bundled(golang(github.com/google/go-cmp)) bundled(golang(github.com/google/go-containerregistry)) bundled(golang(github.com/google/go-github/v30)) bundled(golang(github.com/heroku/color)) bundled(golang(github.com/mattn/go-colorable)) bundled(golang(github.com/moby/sys/mount)) bundled(golang(github.com/onsi/gomega)) bundled(golang(github.com/opencontainers/image-spec)) bundled(golang(github.com/opencontainers/runc)) bundled(golang(github.com/opencontainers/selinux)) bundled(golang(github.com/pelletier/go-toml)) bundled(golang(github.com/pkg/errors)) bundled(golang(github.com/sclevine/spec)) bundled(golang(github.com/sergi/go-diff)) bundled(golang(github.com/sirupsen/logrus)) bundled(golang(github.com/spf13/cobra)) bundled(golang(github.com/willf/bitset)) bundled(golang(github.com/xanzy/ssh-agent)) bundled(golang(golang.org/x/mod)) bundled(golang(gopkg.in/src-d/go-git.v4)) pack pack(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
