https://bugzilla.redhat.com/show_bug.cgi?id=1979316 --- Comment #6 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > "wth community maintained" → "with community-maintained" > I will make the same change as lsp-server and explicitly mention that this is maintained by spyder-IDE team. > > mkdir -p %{buildroot}%{_datadir}/licenses/python3-%{short_name}/license > > install -m 644 %{SOURCE1} %{buildroot}%{_datadir}/licenses/python3-%{short_name} > > Why not just > --- > %prep > cp %{SOURCE1} LICENSE > > %files > %license LICENSE > --- > ? > Fair enough. I will do this. > + package name is OK > + license is acceptable for Fedora (MIT) > + license is specified correctly > + builds and installs OK > + BR/R/P look OK > + rpmlint finds nothing interesting > + fedora-review finds nothing interesting > > Package is APPROVED. > Thanks for the review. > Suggestion: add Supplements:python-lsp-server. Will do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
