[Bug 1979315] Review Request: python-lsp-server - Python implementation of language server protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1979315



--- Comment #9 from Mukundan Ragavan <nonamedotc@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #6)
> > This package provides the community maintained version of python-language-server.
> 
> This is still unclear… Everything in Fedora is "community maintained". I
> assume that
> there's some paid version? Please be more explicit.
> 

Yeah, I should have mentioned spyder-IDE team. I will add spyder-IDE team
explicitly - not palantir or microsoft.

> Review:
> + package name is OK
> + license is acceptable for Fedora (MIT)
> + license is specified correctly
> + builds and installs OK
> + BR/R/P seem correct
> + %check is present and passes
> 
> rpmlint:
> > python-lsp-server.src: E: description-line-too-long C This package provides the community maintained version of python-language-server.
> Please wrap.
> 

Will do.

> fedora-review doesn't find any issues.
> 
> Suggestion: add "Provides:pylsp".
> 

I will do this in import.


> Package is APPROVED.

Thanks for the review.


(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> How is the user supposed to launch this? Should it have a systemd user
> service file?


This package is consumed by editors (at the moment, only spyder). As far as I
know, end user does not run this directly.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux