Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-modemlights-plugin - Modemlights for the Xfce panel https://bugzilla.redhat.com/show_bug.cgi?id=392981 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2007-11-21 05:45 EST ------- (In reply to comment #3) > > Issues: > > 1. Wouldn't a better URL be: > http://goodies.xfce.org/projects/panel-plugins/xfce4-modemlights-plugin > > The Source0 URL seems to be: > http://goodies.xfce.org/releases/xfce4-modemlights-plugin/xfce4-modemlights-plugin-0.1.3.99.tar.bz2 > > 2. rpmlint says: > > xfce4-modemlights-plugin.src:65: W: macro-in-%changelog defattr > > Might need a %% there to escape that word from macro expansion. All valid points, seems like I missed some errors when I reworked the spec. > > 3. Should this 'Requires: ppp' ? Or is it useful without ppp? > I have patched the plugin to use ifup/ifdown by default, so theoretically it can be used for ethernet or wireless devices too, but I guess no one will do that. So I require ppp now. SPEC: http://home.arcor.de/christoph.wickert/fedora/review/xfce4-modemlights-plugin.spec SRPM: http://home.arcor.de/christoph.wickert/fedora/review/xfce4-modemlights-plugin-0.1.3.99-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review