Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfce4-modemlights-plugin - Modemlights for the Xfce panel https://bugzilla.redhat.com/show_bug.cgi?id=392981 ------- Additional Comments From kevin@xxxxxxxxx 2007-11-20 22:39 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: aeab49c57bdaeb12a73486515aae50cd xfce4-modemlights-plugin-0.1.3.99.tar.bz2 aeab49c57bdaeb12a73486515aae50cd xfce4-modemlights-plugin-0.1.3.99.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Spec handles locales/find_lang OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. See below - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Wouldn't a better URL be: http://goodies.xfce.org/projects/panel-plugins/xfce4-modemlights-plugin The Source0 URL seems to be: http://goodies.xfce.org/releases/xfce4-modemlights-plugin/xfce4-modemlights-plugin-0.1.3.99.tar.bz2 2. rpmlint says: xfce4-modemlights-plugin.src:65: W: macro-in-%changelog defattr Might need a %% there to escape that word from macro expansion. 3. Should this 'Requires: ppp' ? Or is it useful without ppp? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review