https://bugzilla.redhat.com/show_bug.cgi?id=1957929 Stephen Gallagher <sgallagh@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #3) > So there are a couple of issues: > > > URL: https://github.com/weldr/lorax > > [..] > > Source0: lorax-templates-rhel-9.0-14.tar.gz > > The URL doesn't point to the actual project, and the Source0 does not point > to a proper upstream SourceURL. > This package provides only data files to support the lorax project. The URL is correct. This dist-git repository will be its own upstream. The tarball is generated by a Makefile included with the sources. I have added a comment to this effect into the specfile to avoid confusion in the future. > > rm -rf $RPM_BUILD_ROOT > > This can be removed, as RPM does this automatically. Done. I also updated the version to 10.0 since ELN is currently tracking towards that release. Spec URL: https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhel/fedora-eln-x86_64/02175846-lorax-templates-rhel/lorax-templates-rhel.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sgallagh/lorax-templates-rhel/fedora-eln-x86_64/02175846-lorax-templates-rhel/lorax-templates-rhel-10.0-1.el110.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
