[Bug 1957929] Review Request: lorax-templates-rhel - RHEL build templates for lorax and livemedia-creator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1957929



--- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> ---
So there are a couple of issues:

> URL:            https://github.com/weldr/lorax
> [..]
> Source0:        lorax-templates-rhel-9.0-14.tar.gz

The URL doesn't point to the actual project, and the Source0 does not point to
a proper upstream SourceURL.

We generally want to avoid packages in Fedora like this, since the upstream
relationship is nonexistent. 

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/

> rm -rf $RPM_BUILD_ROOT

This can be removed, as RPM does this automatically.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux