https://bugzilla.redhat.com/show_bug.cgi?id=1923830 --- Comment #13 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Heya, Looks pretty good. Will give it a full review again this week. Some tweaks that I noticed that got left behind: - please remove the "%global debug_package %{nil}" line. If the package is noarch, it will not generate debuginfo. If it isn't noarch, it *must* generate and include debuginfo. - I don't think this is the right usage for the %ghost macro. As the docs say, files that are generated by the package at runtime should be marked as %ghost. The files here are not so---they are included in the rpm. Since no other package in the Fedora repositories owns these directories, this package should just own these directories, so please remove the %ghost directive there. (Docs: http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html) - the appdata files now go to the metainfodir etc. Please see this: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ - Also, just to double check: is the e-mail you are using in the change log correct, since it does not match your e-mail here on bugzilla? (You should use the e-mail you use here in Bugzilla, which should match the e-mail you provide in the Fedora accounts system). - since COPYING is marked by the %license tag, you do not need to repeat it in the %doc list again. Cheers, Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
