https://bugzilla.redhat.com/show_bug.cgi?id=1923830 --- Comment #12 from niohiani <notinsideofhereiamnotinside@xxxxxxxxx> --- Alright Ankur! I think I've taken care of all the "Musts" by now, along with the other things you pointed out. I did my best to address directory/file ownership via the %ghost directive (which I just learned about); Increased the use of macros as opposed to explicit paths; Marked the license file; Consistently used %{buildroot} instead of $RPM_BUILD_ROOT; Edited the changelog entries for readability. The dedicated repo has also allowed me to remedy the versioning issue. New testing repo for packaging: https://copr.fedorainfracloud.org/coprs/niohiani/Diffuse-Packaging-Test/ Spec: https://download.copr.fedorainfracloud.org/results/niohiani/Diffuse-Packaging-Test/fedora-rawhide-x86_64/02159737-diffuse/diffuse.spec SRPM: https://download.copr.fedorainfracloud.org/results/niohiani/Diffuse-Packaging-Test/fedora-rawhide-x86_64/02159737-diffuse/diffuse-0.6.0-1.fc35.src.rpm If I've missed anything, I'll of course be happy to continue amending the .spec file. Thanks so much for your patience. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
