[Bug 1952329] Review Request: src - Simple Revision Control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1952329



--- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
> Secondly, apologies for the delay - I've had surgery etc but that's another story.

I’m not in a hurry! :-) Best wishes on your recovery.

> git is not needed for most core operations in 'src', just for the fairly exotic git import and export operations. […] Would this be a case for a hint such as 'Suggests: git-core' instead?

If the parts that use git are not essential functionality, and it degrades
gracefully, as you noted, then I think it would be a good fit for a weak
dependency (Recommends:). That way git-core is installed by default but people
wanting minimal installations can use “dnf --setopt=install_weak_deps=False” to
avoid it. Fedora suggests weak dependencies for, e.g., “Plug-ins or add-ons
(Support for file formats, Support for protocols, …)”
(https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/#_weak_dependencies),
which is pretty close to this case.

Looking at
https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/#_hints,
it’s not clear if Fedora exactly forbids using a hint here (is this part of
“the main use cases of a package”)? But in practice a hint does very little for
users. I think a weak dependency is more useful and more consistent with how
weak dependencies and hints are used in the rest of the distribution.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux