[Bug 1906980] Review Request: highway - Efficient and performance-portable SIMD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1906980

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |code@xxxxxxxxxxxxxxxxxx



--- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Because my workstation is an antique, this fails to build in mock for me.

> /usr/bin/cmake -D TEST_TARGET=hwy_test -D TEST_EXECUTABLE=/builddir/build/BUILD/highway-0.11.1/x86_64-redhat-linux-gnu/tests/hwy_test -D TEST_EXECUTOR= -D TEST_WORKING_DIR=/builddir/build/BUILD/highway-0.11.1/x86_64-redhat-linux-gnu -D TEST_EXTRA_ARGS= -D TEST_PROPERTIES= -D TEST_PREFIX= -D TEST_SUFFIX= -D NO_PRETTY_TYPES=FALSE -D NO_PRETTY_VALUES=FALSE -D TEST_LIST=hwy_test_TESTS -D CTEST_FILE=/builddir/build/BUILD/highway-0.11.1/x86_64-redhat-linux-gnu/hwy_test[1]_tests.cmake -D TEST_DISCOVERY_TIMEOUT=60 -D TEST_XML_OUTPUT_DIR= -P /usr/share/cmake/Modules/GoogleTestAddTests.cmake
> CMake Error at /usr/share/cmake/Modules/GoogleTestAddTests.cmake:77 (message):
>   Error running test executable.
>     Path: '/builddir/build/BUILD/highway-0.11.1/x86_64-redhat-linux-gnu/tests/hwy_test'
>     Result: Illegal instruction
>     Output:
> 
> Call Stack (most recent call first):
>   /usr/share/cmake/Modules/GoogleTestAddTests.cmake:173 (gtest_discover_tests_impl)

You will need to make sure that tests using SIMD extensions that are not in the
baseline for the architecture are not executed.

SSE2 is inherently part of x86_64, and we can assume it in Fedora for i686
(https://fedoraproject.org/wiki/Changes/Update_i686_architectural_baseline_to_include_SSE2).
Everything later needs to be checked by grepping /proc/cpuinfo, using the CLI
tool from https://src.fedoraproject.org/rpms/google-cpu_features, or something
similar.

-----

It’s probably worth justifying shipping static libraries in a spec file
comment. In this case it looks like there is simply no upstream support for
building as a shared library.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux