https://bugzilla.redhat.com/show_bug.cgi?id=1930954 --- Comment #5 from Merlin Mathesius <mmathesi@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #4) Thank you for the follow-up. > -License: GPLv2 > -URL: https://github.com/avocado-framework/aexpect > +License: GPLv2+ and GPLv2 > +URL: https://github.com/avocado-framework/%{srcname} > > I see you changed the license to "GPLv2+ and GPLv2". I believe it should be > "GPLv2+". What makes you think there are parts that don't allow later > version? (This is the only remaining blocker for the review.) Confusion on my part. Corrected. > I see you obfuscated the URL so it is harder to copy-paste from the spec > file to the browser. What was the reason to do that? (This is not a blocker > for the review, I am just curious.) Source0 (referenced above in the review) originally started out with https://github.com/avocado-framework/%{srcname}/... After adjusting it to use %{url} instead, I adjusted URL to match the original Source0 prefix referencing %{srcname}. That's all. However, with this SPEC revision, I took your advice from BZ#1930948 (python-avocado review) and entirely dropped the unnecessary complexity and obfuscation of using %{srcname} and %{pkgname}. New Spec URL: https://download.copr.fedorainfracloud.org/results/merlinm/avocado/fedora-rawhide-x86_64/02081530-python-aexpect/python-aexpect.spec New SRPM URL: https://download.copr.fedorainfracloud.org/results/merlinm/avocado/fedora-rawhide-x86_64/02081530-python-aexpect/python-aexpect-1.6.1-2.fc35.src.rpm Thanks again! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
