https://bugzilla.redhat.com/show_bug.cgi?id=1930954 --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Let me comment on the diff: --- python-aexpect.spec.old 2021-03-18 17:53:05.538218893 +0100 +++ python-aexpect.spec 2021-03-18 17:52:52.754132043 +0100 @@ -26,20 +26,22 @@ Name: python-%{pkgname} Version: 1.6.1 -Release: 1%{?gitrel}%{?dist} +Release: 2%{?gitrel}%{?dist} Ack. Summary: A python library to control interactive applications -License: GPLv2 -URL: https://github.com/avocado-framework/aexpect +License: GPLv2+ and GPLv2 +URL: https://github.com/avocado-framework/%{srcname} I see you changed the license to "GPLv2+ and GPLv2". I believe it should be "GPLv2+". What makes you think there are parts that don't allow later version? (This is the only remaining blocker for the review.) I see you obfuscated the URL so it is harder to copy-paste from the spec file to the browser. What was the reason to do that? (This is not a blocker for the review, I am just curious.) %if 0%{?rel_build} -Source0: https://github.com/avocado-framework/%{srcname}/archive/%{version}.tar.gz#/%{gittar} +Source0: %{url}/archive/%{version}/%{gittar} %else -Source0: https://github.com/avocado-framework/%{srcname}/archive/%{commit}.tar.gz#/%{gittar} +Source0: %{url}/archive/%{commit}/%{gittar} %endif Thanks. +# Remove vestigial python shebang line from rss_client.py that causes rpmlint errors. +# https://github.com/avocado-framework/aexpect/commit/a2c8252a36cbe90182774f48948d8e504832bd62.patch +Patch1: python-aexpect-1.6.1-remove-python-shebang.patch Thanks. BuildArch: noarch -Requires: python3 Thanks. BuildRequires: python3-devel BuildRequires: python3-setuptools @@ -58,9 +60,9 @@ %prep %if 0%{?rel_build} -%autosetup -n %{srcname}-%{version} +%autosetup -n %{srcname}-%{version} -p 1 %else -%autosetup -n %{srcname}-%{commit} +%autosetup -n %{srcname}-%{commit} -p 1 %endif Ack. %build @@ -71,8 +73,8 @@ ln -s aexpect_helper %{buildroot}%{_bindir}/aexpect_helper-%{python3_pkgversion} ln -s aexpect_helper %{buildroot}%{_bindir}/aexpect_helper-%{python3_version} -%check %if %{with_tests} +%check selftests/checkall %endif Thanks. @@ -80,10 +82,14 @@ %license LICENSE %doc README.rst %{python3_sitelib}/aexpect/ -%{python3_sitelib}/aexpect-%{version}-py%{python3_version}.egg-info +%{python3_sitelib}/aexpect-%{version}-py%{python3_version}.egg-info/ %{_bindir}/aexpect_helper* Thanks. %changelog +* Wed Mar 17 2021 Merlin Mathesius <mmathesi@xxxxxxxxxx> - 1.6.1-2 +- Spec file cleanup following package review. +- Include upstream patch to fix rpmlint error. + Ack. * Mon Feb 15 2021 Cleber Rosa <cleber@xxxxxxxxxx> - 1.6.1-1 - Sync with upstream release 1.6.1. - Dropped Python2 support completely -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
