https://bugzilla.redhat.com/show_bug.cgi?id=1938181 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Seems the URL is wrong: URL: https://github.com/fcitx/fcitx5 Shouldn't that be: URL: https://github.com/fcitx/mozc - Should be 1 past the release: # upstream don't tag release # build git snapshot Release: 0.0%{?dist} → Release: 1%{?dist} […] * Fri Mar 12 2021 Qiyu Yan <yanqiyu@xxxxxxxxxxxxxxxxx> - 2.17.2102.102.1-1.20210317gitdf9f395 - Remove various trailing spaces - Should be python3-devel BuildRequires: python → BuildRequires: python3-devel - Should run python3 not 'python' PYTHONPATH="${PYTHONPATH}:../../" python3 ../../dictionary/gen_zip_code_seed.py --zip_code=../../../KEN_ALL.CSV --jigyosyo=../../../JIGYOSYO.CSV >> dictionary09.txt; […] python3 build_mozc.py gyp --gypdir=%{_bindir} --server_dir=%{server_dir} --target_platform=Linux python3 build_mozc.py build -c Release server/server.gyp:mozc_server gui/gui.gyp:mozc_tool unix/fcitx5/fcitx5.gyp:fcitx5-mozc - Use install -p to keep timestamps: install -D -pm 755 "out_linux/${_bldtype}/mozc_server" "%{buildroot}%{server_dir}/mozc_server" install -D -pm 755 "out_linux/${_bldtype}/mozc_tool" "%{buildroot}%{server_dir}/mozc_tool" - Add Requires: hicolor-icon-theme to own the icons directories - Please document why these patches are necessary: Patch0: mozc-build-verbosely.patch Patch1: fix-build-gcc11.patch - Try to unbundle the third party s much as you can: abseil-cpp, gtest, gyp, jsoncpp, protobuf are already packaged in Fedora. - See https://src.fedoraproject.org/rpms/mozc/ if you need to lift some patches, notably you should try to build with gcc instead of clang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
