https://bugzilla.redhat.com/show_bug.cgi?id=1933464 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vondruch@xxxxxxxxxx --- Comment #10 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to Davide Cavalca from comment #8) > - per fedora-review, you can actually delete the whole %clean section This is actually SHOULD. It is not needed and while ago, there was put effort into removing the `%clean` sections from all packages. And I have several more remarks actually: * Is this [1] any useful? * The layout of the package is quite nonstandard. I'd expect that the package (including spec file and SRPM) is either name `sugarjar`, if it is considered application, or named `rubygem-sugarjar` otherwise. The current naming makes hard to understand the relation between `sugarjar` RPM and `rubygem-sugarjar` SRPM. There is no other package like this. * The order of preamble also deviates from common order, which makes the package harder to navigate. * We typically tend to use the virtual provides for specifying dependencies, e.g. `BuildRequires: rubygem(rspec)` instead of `BuildRequires: rubygem-rspec`. * We typically tend to run the test suite under the `pushd .%{gem_instdir}`. It is of course possible to run it directly in `%{builddir}`, which is default, but there might be possibly small differences. I'd suggest to use rubygem-gem2rpm to generate the initial boilerplate. [1] https://src.fedoraproject.org/rpms/rubygem-sugarjar/blob/rawhide/f/rubygem-sugarjar.spec#_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
