Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-python - Python bindings for manipulating evolution data https://bugzilla.redhat.com/show_bug.cgi?id=378431 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-11-14 00:00 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM, But NOT for RPM. evolution-python.i386: W: devel-file-in-non-devel-package /usr/lib/pkgconfig/evolution-python.pc ==> We can ignore this for thi spackage instead of creating a -devel for installing single file. + source files match upstream url 2d08555f0a6de288bfcc3b048d98b3e4 evolution-python-0.0.4.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + evolution-python.pc file present. + -devel subpackage not needed for single file. + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package evolution-python-0.0.4-2.fc9 -> Provides: ebook.so ecal.so Requires: libORBit-2.so.0 libbonobo-2.so.0 libbonobo-activation.so.4 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) libdl.so.2 libebook-1.2.so.9 libecal-1.2.so.7 libedataserver-1.2.so.9 libgconf-2.so.4 libgdk_pixbuf-2.0.so.0 libglib-2.0.so.0 libgmodule-2.0.so.0 libgnome-2.so.0 libgobject-2.0.so.0 libgthread-2.0.so.0 libpango-1.0.so.0 libpopt.so.0 libpthread.so.0 librt.so.1 libxml2.so.2 pkgconfig python(abi) = 2.5 rtld(GNU_HASH) + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review