Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: evolution-python - Python bindings for manipulating evolution data https://bugzilla.redhat.com/show_bug.cgi?id=378431 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-11-13 10:57 EST ------- (In reply to comment #1) > 1) remove .la files from installing. Ooops. I did my removal on the wrong directory :) Fixed. > 2) remove unnecessary BR's > pkgconfig,gdk-pixbuf-devel,pygobject2-devel,gtk+-devel.pkgconfig Fixed. > 3) Source URL should be > http://files.conduit-project.org/releases/%{name}-%{version}.tar.gz Fixed. > 4) good to add test files from test directory as %doc Fixed. (In reply to comment #2) > rpmlint complained > evolution-python.i386: W: devel-file-in-non-devel-package > /usr/lib/pkgconfig/evolution-python.pc > A development file (usually source code) is located in a non-devel > package. If you want to include source code in your package, be sure to > create a development package. If I put the .pc file in a -devel package it will be the only file in the package. This seems silly. There has been discussion in the past on the packaging list whether this rule should be bent or not for this particular case. I'm in the camp that thinks it should ;) You can see this same behavior in packages like tomboy and beagle as well (although that's no excuse). Spec URL: http://bjohnson.fedorapeople.org/evolution-python.spec SRPM URL: http://bjohnson.fedorapeople.org/evolution-python-0.0.4-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review