[Bug 1932616] Review Request: rttr - Run Time Type Reflection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1932616



--- Comment #3 from Sergio Basto <sergio@xxxxxxxxxx> ---
Created attachment 1759462
  --> https://bugzilla.redhat.com/attachment.cgi?id=1759462&action=edit
rttr.spec.patch

Hi,

Issues:
=======
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license_8md.html is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

/usr/share/doc/rttr-doc/rttr-0-9-6/license_8md.html
/usr/share/doc/rttr-doc/rttr-0-9-6/license_page.html
these files are fine 

so no issues 

but 
please fix doc file permissions : 

-find __doc -type f -exec chmod 0640 {} ';'
+find __doc -type f -exec chmod 0644 {} ';'

Also notice the name convention is not the standard on Fedora packages should
be rttr-libs and rttr-devel .


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux