https://bugzilla.redhat.com/show_bug.cgi?id=1908526 --- Comment #4 from noon@xxxxxxxxxxx --- Thanks for your review, it is very helpful and gives me lots of pointers for my next iteration. I was wondering why I had so much trouble finding how to register info files... Now I understand: it's implicit ;) Concerning EPEL, this is not the target of this submission, but I will certainly try to make an EPEL8 package if and when this one succeeds. As far as I understood, in Fedora this is done by creating a specific branch, so I'll put changes like "python3-setuptools" in that branch. %pyproject_buildrequires -x tests is indeed helpful, however it finds more BuildRequires than I think necessary; in particular it requires the PyPI packages doubles and flake8-quotes: - doubles is not used in the code (no import whatsoever), I guess upstream intends to use it in the future - flake8-quotes aims at forcing the use of e.g. single quotes in Python None of these two seem to exist as Fedora packages. So I think I'll stick to a manual list of BuildRequires... Thanks to your review, I've learned about fedora-review. After corrections from your input, it still complains about two particular things: a deprecated package, and Info documentation. Package must not depend on deprecated() packages. Note: python3-mock is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/. I'm pushing upstream to remove the dependency when Py3.3+ is there. See issue https://github.com/opentracing/opentracing-python/issues/142 and associated PR. Depending on upstream's reactivity, I might add a patch to the package. Texinfo files are installed using install-info in %post and %preun if package has .info files. Note: Texinfo .info file(s) in python3-opentracing See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_texinfo Maybe this is not relevant: the link anchor is not found, and you told me to remove the post/preun that I originally put... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
