https://bugzilla.redhat.com/show_bug.cgi?id=1908526 code@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |code@xxxxxxxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from code@xxxxxxxxxxxxxxxxxx --- This is a great start! Some preliminary notes: ----- You do not need: # This is to avoid this error: # error: Empty %%files file /builddir/build/BUILD/opentracing-python-2.4.0/debugsourcefiles.list %global debug_package %{nil} Instead, since there is nothing architecture-specific (such as compiled extensions) in this package, add BuildArch: noarch to the top-level package “python-opentracing“; you may then remove it from the subpackages. ----- Unless you are planning to build for EPEL with the same spec file, Python dependencies are best written like: BuildRequires: python3dist(setuptools) rather than BuildRequires: python3-setuptools See https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatic_provides_with_a_standardized_name. ----- You can use https://src.fedoraproject.org/rpms/pyproject-rpm-macros to generate the BuildRequires for you. See https://src.fedoraproject.org/rpms/python-junit_xml/blob/rawhide/f/python-junit_xml.spec for a Python package I maintain that uses the full suite of macros. Using these macros is not mandatory, but it is very helpful and highly recommended. ----- All of this: Requires(post): info Requires(preun): info %post -n python3-opentracing /sbin/install-info %{_infodir}/%{pypi_name}.info %{_infodir}/dir || : %preun -n python3-opentracing if [ $1 = 0 ] ; then /sbin/install-info --delete %{_infodir}/%{pypi_name}.info %{_infodir}/dir || : fi is now handled by path triggers and is obsolete. Packaging has gotten a lot simpler in some ways since RHEL5–6. ----- I don’t think this is yet in the guidelines, but make is no longer in the buildroot, so you will need to add BuildRequires: make ----- Change cp docs/_build/texinfo/%{pypi_name}.info %{buildroot}%{_infodir}/ to cp -p docs/_build/texinfo/%{pypi_name}.info %{buildroot}%{_infodir}/ to preserve timestamps. ----- Change %{_infodir}/%{pypi_name}.info.gz to %{_infodir}/%{pypi_name}.info* to accommodate possible changes in info page compression. ----- Consider replacing %{__make} -C docs info PYTHONPATH=.. with %make_build -C docs info PYTHONPATH=.. ----- Consider also building the HTML documentation (just add the html target when you build the info page) and providing it in a -doc subpackage. ----- Some files are under an MIT license instead of the overall ASL 2.0 license. You must follow https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios. You can use “licensecheck” to help you find these files. ----- Consider running the “fedora-review” tool yourself to see what a reviewer will be a starting with. (I did not use it on this package yet because it would not build due to the missing make BR.) ----- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
