https://bugzilla.redhat.com/show_bug.cgi?id=1925759 --- Comment #2 from frederic.pierret@xxxxxxxxxxxx --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > %{_datadir}/man/man1/disorderfs.1.gz > → %{_datadir}/man/man1/disorderfs.1* > (We might want to change the default compression alg at some point.) Fixed. > Maybe update to 0.5.11? I've updated the version. > Are the tags under https://reproducible-builds.org/_lfs/releases/disorderfs/ > reliable? > If yes, then we'd want to have signature verification as described in > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_source_file_verification Yes they are, notably I've reviewed it with upstream and also ask them to publish the keyring. I've updated the code accordingly the guidelines. I've added the keyring hash into "sources" file too. Should I add it into the git repo too? > > %doc README > The README has no useful information. > Maybe do '%doc NEWS' instead? NEWS is older and looks like some kind of changelog. I propose you to help upstream in updating the current README for which they refer to https://salsa.debian.org/reproducible-builds/disorderfs/-/blob/master/disorderfs.1.txt for information but few useful info can be extracted to the README. What do you think? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
