https://bugzilla.redhat.com/show_bug.cgi?id=1919347 d.hatayama@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(d.hatayama@fujits | |u.com) | --- Comment #11 from d.hatayama@xxxxxxxxxxx --- Nathan, Thanks for your reviewing. (In reply to Nathan Scott from comment #10) > Hi Hatayama, > > I've completed the first round of 'formal' review now. In addition to the > docs topic discussed earlier (mentioned below in the review re %doc files, As I mentioned before, I don't think I add README in the rpm package for the time being. > up to you whether you want to include that README) there's one other small > issue worth fixing, i.e. > > No package seems to own the crash/extensions directory? > > $ rpm -qf /usr/lib64/crash > file /usr/lib64/crash is not owned by any package > > You can add ownership of these to your new package (it is OK if multiple > packages own these directories too BTW - although ideally 'crash' itself > would have provided them I guess) - by adding the following to %files .. > > %dir %{_libdir}/crash > %dir %{_libdir}/crash/extensions I've added these lines just as indicated. Here's the update: Spec URL: http://raw.githubusercontent.com/d-hatayama/crash-modules-fedora-package-review/master/crash-gcore-command.spec SRPM URL: https://github.com/d-hatayama/crash-modules-fedora-package-review/raw/master/crash-gcore-command-1.6.2-1.fc33.src.rpm Thanks. HATAYAMA, Daisuke -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
