[Bug 1924918] Review Request: reprotest: Build packages and check them for reproducibility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1924918



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
For rstr:

> License:        None
It needs to be one of the license under
https://fedoraproject.org/wiki/Licensing:Main#Software_License_List.

> %if %{with tests}
> BuildRequires:  python3dist(rstr)
> %endif

That's be super annoying. In particular it'd complicate bootstrapping to each
next python version.
Instead of doing that, just add PYTHONPATH=%buildroot%{python3_sitelib} for the
tests.

Don't repeat the description text. Instead do:
%global _description %{expand:
<the text here>}

%description %_description

%description -n python%{python3_pkgversion}-%{pypi_name} %_description

> It has no dependencies outside the standard library, and should
> be compatible with Python 3.

Drop this. There's nothing except python 3 and users don't need to care about
dependencies,
packaging metadata takes care of this for them ;)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux