https://bugzilla.redhat.com/show_bug.cgi?id=1807365 --- Comment #19 from Dimitrij Mijoski <dmjpp@xxxxxxxxxxx> --- (In reply to vishal vijayraghavan from comment #18) > Nuspell package updated[1] to latest release 4.2.0. > This update is build currently for rawhide only, please review and suggest > updates if any. > Thanks :) > > [1] https://src.fedoraproject.org/rpms/nuspell/blob/master/f/nuspell.spec First I would like to thank you for maintaining this package. I'll suggest updates: Line 4 should be changed from: Summary: C++ spelling checking library and command-line tool to Summary: C++ spellchecking library and command-line tool The following lines are most likely not needed, thus they should be deleted: 8: BuildRequires: boost-locale 9: BuildRequires: clang 11: BuildRequires: gcc 13: BuildRequires: git 15: BuildRequires: rdkit-devel Boost used to be required but now it is not. Clang is not needed, gcc-c++ is already ok. gcc-c++ also implies gcc, no need to specify gcc when gcc-c++ is there. Git is not needed. I don't know what rdkit is. Giving a quick web-search, I can say it has no relation to this package. Line 38 and 39 can be simplified from: 38: %cmake -DCMAKE_BUILD_TYPE=Release \ 39: -DCMAKE_INSTALL_PREFIX=%{_prefix} to just: %cmake -DCMAKE_BUILD_TYPE=Release Install prefix is automatically specified by the %cmake thing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
