https://bugzilla.redhat.com/show_bug.cgi?id=1884608 --- Comment #22 from Patryk Obara <dreamer.tan+fedora@xxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/dosbox-staging/dosbox-staging/master/contrib/fedora/dosbox-staging.spec Spec diff: https://github.com/dosbox-staging/dosbox-staging/commit/a827baa1b2cddd6cea166cafd6b597c568eac58d SRPM URL: https://github.com/dosbox-staging/dosbox-staging.github.io/releases/download/artifacts/dosbox-staging-0.76.0-1.fc33.src.rpm Koji f33 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60490850 Koji f34 build: https://koji.fedoraproject.org/koji/taskinfo?taskID=60491350 (In reply to Hans de Goede from comment #17) > TODO / FIXME > ============ > [!]: Package consistently uses macros > > You use %{__make} in %build and just plain "make" > in %install. Please be consistent. Note you can also choose to use: > "%{make_build}" instead of "%{__make} %{_smp_mflags}" and > "%{make_install}" instead of "%{__make} install DESTDIR=%{buildroot}" > > Also there is no need to pass " -n %{name}-%{version}" to > "%autosetup" as that is the default, so please drop this. Done and done :) > [!]: If the package is a rename of another package, proper Obsoletes and > Provides are present. > > Provides: dosbox = %{version}-%{release} > Obsoletes: dosbox < %{version}-%{release} Done. I also tested if dosbox-staging is correctly picked by Wine and it works exactly as it should :) When Wine is instructed to run DOS executable, it delegates the job to dosbox binary, picking dosbox-staging. Wine package in Fedora does not depend on dosbox explicitly. > This will switch users to the new dosbox-staging automatically during > update > installation. Tested it and indeed, dnf replaced the package automatically now instead of failing due to the conflict as before. > [!]: Latest version is packaged. Done. > [!] Missing BuildRequires: make Done, and Koji build on f34 finished without a problem. > [!] Missing BuildRequires: fluidsynth-devel This is a new dependency for 0.76.0, that's why it was omitted earlier. One thing I forgot to add in spec 0.76.0-1 - we actually depend on FluidSynth >= 2.0 (therefore this spec file won't work for Fedora 32 which ships FluidSynth 1.1). Should I specify the package version in here? There's also a similar story for SDL2 - we specifically depend on >= 2.0.2 (but all Fedora versions provide it). I also added another dependency (runtime only, not a build dependency): fluid-soundfont-gm - it's the package providing FluidR3 soundfont and setting up default.sf2 symlink - thanks to this, users who want to use FluidSynth MIDI feature have high-quality default soundfont installed out of the box. > [?] Missing BuildRequires: zstd This is a bug in our documentation/scripts - at the moment we do not depend on zstd. We use it for compressing certain artifacts on CI and the dependency made its way to some scripts. To be fixed on our master branch. > Patryk, if you can post a new version with these items resolved > then I can approve the package and sponsor you to become a > packager. To sponsor you I also need to know your Fedora > Account System (FAS) username. My FAS username is: pbo (In reply to Hans de Goede from comment #20) > > The feature loss is limited to playing audio from physical game CDs, which I > doubt has a lot of users. Yes, it's not really used any more. Over last year we had 3 users complain about it. 1 user misunderstood the scope of the change, 2 users were not using physical CDs anyway, but rather were mounting CD images using some Windows virtual drive software (as opposed to using built-in functionality: imgmount command). The feature was removed because SDL2 dropped support for library SDL_cdrom (also due to lack of interest). > The current Fedora dosbox package OTOH is pretty broken, e.g. in Fedora 33 > the cursor-keys do not even work (I don't know when they broke, but atm they > are definitely broken). I did not check, but I guess that this is caused by > the original dosbox shipping with a patched SDL1 and our packages using the > system SDL1 Yes, in vanilla DOSBox cursor keys are broken when using Wayland. There are other critical issues as well: input breaks in certain games when starting in fullscreen (both X11 and Wayland), multi-display setups break badly (both X11 and Wayland), CD-DA emulation for some formats simply does not work (due to obsolete SDL_sound 1.2 library), etc… dosbox-staging fixes all of these problems, but we do have some important known issues to fix still. (In reply to Kamil Páral from comment #21) > I also see that "windowresolution=X%" option is no longer supported in the > config file. But yes, judging just from that table, the differences seem > very small. This feature was never released by vanilla DOSBox - it exists only on SVN trunk. We removed it because it's not well-thought-out (it's unclear what % is supposed to refer to - might be screen resolution/desktop area/original game resolution, etc), and it conflicts conceptually with support for a resizable window. Originally I intended dosbox-staging to be installable as an alternative to dosbox, and suggest replacing maybe for f35 (if everything worked well), but I am ok with having faster schedule :) Especially with François on board with this change (as indicated in mail discussion). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
