[Bug 187317] Review Request: mindi - Creation of emergency boot disks/CDs using your kernel, tools and modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=187317

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebob.m@xxxxxxxxx



--- Comment #49 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
 - This need to be justified or fixed:

# Avoids to generate debug packages
%global debug_package %{nil}

 - Again why the non standard release info:

Release:        0.20201118013837.s3776M%{dist}

It should be 1.

 - Not used in Fedora

Group:

 - Not needed  

BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(id -u -n)


 - Not available for me:

Source:        
ftp://ftp.mondorescue.org/test/src/%{srcname}-%{version}.0.20201118013837.tar.gz

 - I don't think we support ia64 anymore.

 - Please justify this

ExclusiveArch:  x86_64 i586 i386 i686 ia64

Why can't it be compiled on other arches?

 - Not needed:

rm  -rf $RPM_BUILD_ROOT


%clean
rm -rf $RPM_BUILD_ROOT

%defattr(-,root,root)

 - The license file must be installed with %license in %files:

%license COPYING


 - Is there a reason this is not noarchc it seems to be all perl and bash. You
should probably add:

BuildRequires:  perl-generators
BuildRequires:  perl-interpreter


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux