https://bugzilla.redhat.com/show_bug.cgi?id=678809 Carl George <carl@george.computer> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |carl@george.computer Flags| |needinfo?(sebastien.willman | |n@xxxxxxxxx) --- Comment #45 from Carl George <carl@george.computer> --- Sébastien, are you still interested in having this reviewed? The www.seeks-project.info domain appears to have expired and is parked. It seems the new homepage is https://beniz.github.io/seeks/, so the URL field in your spec file needs updating. Some other pointers: - remove Group tag (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections) - use %make_build (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make) - use %make_install (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_why_the_makeinstall_macro_should_not_be_used) - use %license for the licensing files (Licenses and COPYING) (https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/) - it's no longer necessary to call ldconfig in scriptlets, remove it (https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets) I am also slightly concerned that this project is dead upstream. The commit was in 2014. The last maintainer response to a pull request or issue was 2016. Skimming https://github.com/beniz/seeks/issues/27 also makes it sound like the maintainer is no longer interested in the project. Fedora should not be adding dead software. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
