[Bug 1906490] Review Request: python-setuptools-rust - Setuptools Rust extension plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1906490



--- Comment #10 from Christian Heimes <cheimes@xxxxxxxxxx> ---
0) Let's do it right from the beginning. I have added "BuildRequires: 
rust-packaging" and "ExclusiveArch:  %{rust_arches}".

1) Fixed the the typo in changelog date.

2) I have opened https://github.com/PyO3/setuptools-rust/pull/102 . In the mean
time let's keep the manual requirement. I'll remove it when there is a version
of setuptools_rust with the fix available.

3) I didn't know that %python_provide is deprecated. I have replaced it with
%py_provides

4) The comment is gone.

5) Good idea, CHANGELOG.md is now included.

6) pyp2rpm comment is gone


https://cheimes.fedorapeople.org/python-setuptools-rust/ contains updated spec
file and SRPM.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux