https://bugzilla.redhat.com/show_bug.cgi?id=1914369 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from José Matos <jamatos@xxxxxxxx> --- (In reply to Christoph Karl from comment #4) > Thank you very much for the review. > > Sorry about the strange spec file. The spec file is OK. My point is that the urls that you give should be the raw versions, just like you did for the srpm. :-) > I removed the line > %{?python_provide:%python_provide python3-%{srcname}} > > It's unlikely that there will be a Fedora 32 package that depends on > python3-pyswip before Fedora 32 is retired. OK. > I also removed "-p1" from autosetup because there is currently no patch > needed. I noticed that when reviewing the package. It could be there since that does not change the behavior of the package it is OK to let it IMHO. Certainly that package is clean without it. :-) I could cite the Zen of Python. :-) So this is fine. > Result can be found here: > https://src.fedoraproject.org/fork/pampelmuse/rpms/python-pyswip/commits/ > master > > Koji build here: > https://koji.fedoraproject.org/koji/taskinfo?taskID=59249635 Again the point is that you should have placed the raw links. I sometimes use helper scripts, just like fedora-review. That is why there is a template with the "Spec URL:" and "Spec URL:" lines in evidence. E.g. fedora-review will always pick the last version from there. This is more a matter of principle since in this case the change is minimal and in this case practical. The package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
