https://bugzilla.redhat.com/show_bug.cgi?id=1910141 --- Comment #3 from Pavel Valena <pvalena@xxxxxxxxxx> --- Thank you for your quick review! TBH I've not checked the package much, as it's needed for Ruby 3.0 rebuilds, which I'm focused on now. (In reply to Jaroslav Prokop from comment #2) > Licensing: > * License: BSD-2-Clause [0] should be just BSD [1] according to licensing > guidelines. Maybe just add a note above specifying that it is BSD-2-Clause? Yes, you're right, I'll fix it to `BSD`. > * Is the `Ruby license` specified in the `License:` field required? (If so, > why? I am curious a bit myself) `Ruby` is a valid license, but it's not in the repo itself, so I've created an issue: https://github.com/ruby/webrick/issues/64 The response was Ruby is the correct License as well. I'll keep both then. > > One small nit: > * The `%{gem_instdir}/bin` could be in my opinion excluded. It adds nothing > meaningful for users as they are there just for development purposes. Good catch! I'll move it into doc subpackage. > > The package builds and works so it looks good to go after clarifying the > licensing. > > [0] https://fedoraproject.org/wiki/Licensing:BSD?rd=Licensing/BSD#2ClauseBSD > [1] > https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses Here's the fixed spec and SRPM: https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01847159-rubygem-webrick/rubygem-webrick.spec https://download.copr.fedorainfracloud.org/results/pvalena/rubygems/fedora-rawhide-x86_64/01847159-rubygem-webrick/rubygem-webrick-1.7.0-1.fc34.src.rpm And the diff: https://git.io/JLPQv (I'll re-add the Ruby license, as per the upstream response.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
