https://bugzilla.redhat.com/show_bug.cgi?id=1910141 --- Comment #2 from Jaroslav Prokop <jar.prokop@xxxxxxxx> --- Licensing: * License: BSD-2-Clause [0] should be just BSD [1] according to licensing guidelines. Maybe just add a note above specifying that it is BSD-2-Clause? * Is the `Ruby license` specified in the `License:` field required? (If so, why? I am curious a bit myself) One small nit: * The `%{gem_instdir}/bin` could be in my opinion excluded. It adds nothing meaningful for users as they are there just for development purposes. The package builds and works so it looks good to go after clarifying the licensing. [0] https://fedoraproject.org/wiki/Licensing:BSD?rd=Licensing/BSD#2ClauseBSD [1] https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
