https://bugzilla.redhat.com/show_bug.cgi?id=1907238 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > BuildRequires: cmake gcc gcc-c++ One-per-line is preferred nowadays. > %{_bindir}/* Maybe '%{_bindir}/exr*' ? This will make it less likely to something unintended to slip in on upgrades. rpmlint: openexr.src: W: spelling-error %description -l en_US containes -> contained, contains, containers > # Is it OK to dump the libraries in site-packages? It means that the modules 'iex' and 'imath' will be importable in the global namespace. It's certainly allowed in general. I think the name is a bit generic in this case, but it's not something we have influence over. + license is acceptable for Fedora (BSD 3 clause) + license is specified correctly + builds and installs OK + BR and Requires look correct + Provides and Obsoletes look correct took Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
