[Bug 1881169] Review Request: lz4-java - LZ4 compression for Java

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1881169



--- Comment #10 from Alex Macdonald <almacdon@xxxxxxxxxx> ---
SPEC URL:
https://src.fedoraproject.org/fork/almac/rpms/lz4-java/blob/master/f/lz4-java.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/almac/lz4-java/fedora-33-x86_64/01808727-lz4-java/lz4-java-1.7.1-9.fc33.src.rpm

Thank you Severin for the comments, I've addressed the comments you've added in
my latest commits.

Previously I was bundling lz4, and have changed this to use BR lz4-devel &
xxhash-devel instead, and now compile the JNI files manually to drop the
dependency on cpptasks. I did this by introducing a basic Makefile in a patch
[0], that compiles the JNI files and generates the expected shared object
"liblz4-java.so".

The tests were previously disabled because of a lack of the randomizedtesting
dependency, however there are quite a few tests that can run without that
dependency so I've tweaked the build.xml to run those test classes now. There's
a unit test in LZ4FrameIOStreamTest that uses LZ4 CLI, so there's a BR on lz4
now.

Successful Copr Build:
https://download.copr.fedorainfracloud.org/results/almac/lz4-java/fedora-rawhide-x86_64/01808727-lz4-java/builder-live.log.gz

[0]
https://src.fedoraproject.org/fork/almac/rpms/lz4-java/blob/master/f/2-remove-cpptasks.patch#_1


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux