https://bugzilla.redhat.com/show_bug.cgi?id=1881169 --- Comment #9 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- A couple of comments: 1. lz4-java seems to include lz4 itself (in the current form) 2. lz4 included in this spec also include xxhash 3. lz4[1] and xxhash[2] are available in Fedora themselves 4. If the spec was changed to use system xxhash and lz4, then what's left to compile with cpptasks is two JNI files. Consider compiling those manually and drop the build dependency on cpptasks. cpptasks seems seems largely dead upstream. No release since 2008. 5. Why are tests disabled? I'd try to run the tests during the build. 6. If you opt to include lz4 with lz4-java, then a 'Provides: bundled(lz4) = <version>' is needed. [1] https://koji.fedoraproject.org/koji/packageinfo?packageID=17099 Add BR: lz4-devel [2] https://koji.fedoraproject.org/koji/packageinfo?packageID=25457 Add BR: xxhash-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
