https://bugzilla.redhat.com/show_bug.cgi?id=1902978 --- Comment #5 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to Michel Alexandre Salim from comment #4) > This mostly looks good, except: > > - -devel doesn't own %{_includedir}/pystring. You can use it instead of > %{_includedir}/pystring/pystring.h, or add a %dir %{_includedir}/pystring Easy enough to fix :) > - I'm not sure how stable the API/ABI is. The project seems stable, so maybe > this is fine, but you might want to consider deriving the SOVERSION from the > version instead of setting it to 0.0. Then again it's not seen a release for > 8 years so you're probably fine. I pretty much re-created the soversion from the manual Makefile. Hopefully my CMake file is accepted upstream and they bump it as appropriate. > - try and shorten the summary if you can Yeah, a lot of upstreams don't provide a clean one-liner description and I haven't gotten a clear answer on how long is too long when asked in the past :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
